Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): fix object debug marker not having point #5577

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

fix object polygon is not available for passParkedObject situation

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 14, 2023
@rej55 rej55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 14, 2023
@rej55 rej55 enabled auto-merge (squash) November 14, 2023 06:57
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (60a51e0) 15.23% compared to head (0fb51c5) 15.23%.
Report is 3 commits behind head on main.

Files Patch % Lines
.../scene_module/goal_planner/goal_planner_module.cpp 0.00% 67 Missing ⚠️
.../src/scene_module/side_shift/side_shift_module.cpp 0.00% 1 Missing and 2 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 50.00% 2 Missing ⚠️
...nner/scene_module/side_shift/side_shift_module.hpp 0.00% 1 Missing ⚠️
...g/behavior_path_planner/src/marker_utils/utils.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5577      +/-   ##
==========================================
- Coverage   15.23%   15.23%   -0.01%     
==========================================
  Files        1717     1717              
  Lines      118404   118383      -21     
  Branches    37930    37924       -6     
==========================================
- Hits        18036    18032       -4     
+ Misses      79720    79701      -19     
- Partials    20648    20650       +2     
Flag Coverage Δ *Carryforward flag
differential 12.68% <2.63%> (?)
total 15.23% <ø> (+<0.01%) ⬆️ Carriedforward from 60a51e0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit dc5d76a into autowarefoundation:main Nov 14, 2023
30 of 32 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lane-change-debug-obj-marker branch November 14, 2023 07:34
santosh-sanku pushed a commit to Interplai/autoware.universe that referenced this pull request Nov 14, 2023
santosh-sanku pushed a commit to Interplai/autoware.universe that referenced this pull request Nov 14, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants